Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Level): Convert level to typescript #2450

Merged
merged 7 commits into from Jul 8, 2019

Conversation

@jessiehuff
Copy link
Contributor

jessiehuff commented Jul 3, 2019

Fixes #2449

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jul 3, 2019

PatternFly-React preview: https://patternfly-react-pr-2450.surge.sh

Jessie
Jessie added 2 commits Jul 5, 2019
Jessie
Jessie
Jessie
Copy link
Contributor

tlabaj left a comment

LGTM

Jessie
Copy link
Contributor

redallen left a comment

LGTM

@jschuler

This comment has been minimized.

Copy link
Collaborator

jschuler commented Jul 8, 2019

@jessiehuff Does it matter what gets passed into the gutter prop? Seems like the component only has 'pf-m-gutter' and no other variations for sm, md, lg

@redallen

This comment has been minimized.

Copy link
Contributor

redallen commented Jul 8, 2019

@jschuler It hasn't for quite some time. Gutter sizes don't exist for layouts. That's what she's addressing in #2421 .

@jessiehuff

This comment has been minimized.

Copy link
Contributor Author

jessiehuff commented Jul 8, 2019

@jschuler Right now it doesn't matter what gets passed to the gutter prop, and the sizes don't really do anything. When I talked to Coker, he told me that they'd decided to remove the sizes in core so I created this PR, but it seems there's still discussion about how to handle it.

@kmcfaul
kmcfaul approved these changes Jul 8, 2019
@jschuler

This comment has been minimized.

Copy link
Collaborator

jschuler commented Jul 8, 2019

Ah, gotcha, thanks! At first it seemed to me that the variations accidentally got dropped but now it makes sense :)

@redallen redallen dismissed jschuler’s stale review Jul 8, 2019

Changed back to getGutterModifer

@redallen redallen merged commit 5c891a0 into patternfly:master Jul 8, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jul 8, 2019

Your changes have been released in:

  • @patternfly/react-core@3.64.0
  • @patternfly/react-docs@4.8.62
  • @patternfly/react-inline-edit-extension@2.9.25
  • demo-app-ts@2.6.0
  • @patternfly/react-integration@2.6.0
  • @patternfly/react-table@2.13.56
  • @patternfly/react-topology@2.5.6
  • @patternfly/react-virtualized-extension@1.1.58

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.