Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(login page): removes ariaLabel from checkbox #2455

Merged
merged 5 commits into from Jul 11, 2019

Conversation

@jenny-s51
Copy link
Contributor

jenny-s51 commented Jul 3, 2019

closes #1737

@jenny-s51 jenny-s51 requested review from dlabaj, jgiardino and tlabaj Jul 3, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jul 3, 2019

PatternFly-React preview: https://patternfly-react-pr-2455.surge.sh

@jgiardino

This comment has been minimized.

Copy link
Collaborator

jgiardino commented Jul 3, 2019

These updates look good! The only question I have is whether this would be a breaking change (and if so, are there any changes we can make now without waiting for a breaking change release)? I'm not able to test what happens if rememberMeAriaLabel is defined on <LoginForm> (for some reason, the code editor section is read-only).

@jenny-s51

This comment has been minimized.

Copy link
Contributor Author

jenny-s51 commented Jul 3, 2019

@jgiardino thank you for your feedback! I'm curious as well -- @tlabaj would this be a breaking change?

@@ -97,7 +97,6 @@ export const LoginForm: React.FunctionComponent<LoginFormProps> = ({
label={rememberMeLabel}
checked={isRememberMeChecked}
onChange={onChangeRememberMe}
aria-label={rememberMeAriaLabel || rememberMeLabel}

This comment has been minimized.

Copy link
@dgutride

dgutride Jul 5, 2019

Member

This looks good to me - let's add one more comment up above in rememberMeAriaLabel (to the comment section noting this propType is now deprecated and is no longer used in the code. Also, please open an issue with a breaking change label indicating we should delete this propType in a future breaking change release.

This comment has been minimized.

Copy link
@jenny-s51

jenny-s51 Jul 5, 2019

Author Contributor

Just pushed again with this addition to the comment. Should be all set now -- made a new breaking change issue as well.

@tlabaj

This comment has been minimized.

Copy link
Contributor

tlabaj commented Jul 5, 2019

Can you mention new issue here please? Thnaks.

@jenny-s51

This comment has been minimized.

Copy link
Contributor Author

jenny-s51 commented Jul 5, 2019

@tlabaj It's #2464 🙂

@jenny-s51 jenny-s51 requested a review from dgutride Jul 8, 2019
@tlabaj tlabaj assigned jessiehuff and unassigned jenny-s51 Jul 10, 2019
@tlabaj
tlabaj approved these changes Jul 11, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj merged commit 3cf57e3 into patternfly:master Jul 11, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jul 11, 2019

Your changes have been released in:

  • @patternfly/react-core@3.70.1
  • @patternfly/react-docs@4.8.74
  • @patternfly/react-inline-edit-extension@2.9.37
  • demo-app-ts@2.11.1
  • @patternfly/react-integration@2.11.1
  • @patternfly/react-table@2.14.11
  • @patternfly/react-topology@2.6.8
  • @patternfly/react-virtualized-extension@1.1.70

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.