Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): removed ariaLabel from grouped checkbox select #2456

Merged
merged 1 commit into from Jul 5, 2019

Conversation

@jenny-s51
Copy link
Contributor

jenny-s51 commented Jul 3, 2019

closes #1738

@jenny-s51 jenny-s51 requested review from dlabaj, jgiardino and tlabaj Jul 3, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jul 3, 2019

PatternFly-React preview: https://patternfly-react-pr-2456.surge.sh

@jenny-s51 jenny-s51 self-assigned this Jul 3, 2019
@tlabaj
tlabaj approved these changes Jul 3, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj assigned tlabaj and unassigned jenny-s51 Jul 3, 2019
@redallen redallen merged commit 415a462 into patternfly:master Jul 5, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@jenny-s51 jenny-s51 deleted the jenny-s51:iss1738 branch Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.