Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(BreadCrumbSwitcher): Fix Autocomplete camelCase #2457

Merged
merged 1 commit into from Jul 9, 2019

Conversation

@glekner
Copy link
Contributor

glekner commented Jul 4, 2019

What:
React requires camelCase for DOM attributes, we need to change autocomplete to autoComplete in PF.

React requires camelCase for DOM attributes, we need to change autocomplete to autoComplete in PF.
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jul 4, 2019

PatternFly-React preview: https://patternfly-react-pr-2457.surge.sh

@tlabaj

This comment has been minimized.

Copy link
Contributor

tlabaj commented Jul 5, 2019

@glekner can you add the associated issue to the description please.

@@ -25,7 +25,7 @@ class BreadcrumbSearchInput extends React.Component {
inputRef={input => {
this.nameInput = input;
}}
autocomplete="off"

This comment has been minimized.

Copy link
@redallen

redallen Jul 5, 2019

Contributor

Since this is just a prop passed down to the DOM in https://github.com/nkbt/react-debounce-input/blob/master/src/Component.js, this is good.

@glekner

This comment has been minimized.

Copy link
Contributor Author

glekner commented Jul 9, 2019

@jeff-phillips-18 can we merge? thanks!

@jeff-phillips-18 jeff-phillips-18 merged commit eb3e23a into patternfly:master Jul 9, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jul 9, 2019

Your changes have been released in:

  • patternfly-react-extensions@2.19.5
  • patternfly-react@2.36.5
  • @patternfly/react-console@1.11.5

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.