Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): make pf3/pf4 build on windows #2471

Merged
merged 4 commits into from Jul 8, 2019
Merged

fix(build): make pf3/pf4 build on windows #2471

merged 4 commits into from Jul 8, 2019

Conversation

@redallen
Copy link
Contributor

redallen commented Jul 8, 2019

What: A few things were necessary for Windows support.

  • Replace ' with \" in build scripts because Windows' cmd is weird.
  • Fix PF3 sass importer and remove sassIncludes because we can't rely on yarn hoisting being the same cross-platform.
  • Fix PF4 react-styles path generation to not include an incorrect full path.
  • Force hoisting react-bootstrap-typeahead, xterm, react-diff-view, and react-virtualized.
  • Fix SASS imports for pf3 storybook docs
  • Fix SASS/LESS typeahead import

Additional issues: Fixes #2469 . @TimoSta PatternFly should build on Windows again!! Let me know if this works for you.

@redallen redallen force-pushed the fix/windows branch from b6e0eb8 to d78a66e Jul 8, 2019
@TimoSta

This comment has been minimized.

Copy link
Contributor

TimoSta commented Jul 8, 2019

@redallen Nice! I'll try to find a minute over the next few days to give it a try and report back.

I appreciate that you guys make Windows a priority as well! :)

@dlabaj
dlabaj approved these changes Jul 8, 2019
Copy link
Contributor

dlabaj left a comment

LGTM thanks @redallen

@dlabaj dlabaj merged commit 5bbc4a2 into master Jul 8, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jul 8, 2019

Your changes have been released in:

  • patternfly-react-extensions@2.19.4
  • patternfly-react@2.36.4
  • @patternfly/react-console@1.11.4
  • @patternfly/react-charts@4.4.14
  • @patternfly/react-core@3.66.1
  • @patternfly/react-docs@4.8.65
  • @patternfly/react-inline-edit-extension@2.9.28
  • demo-app-ts@2.7.1
  • @patternfly/react-styled-system@3.6.11
  • @patternfly/react-styles@3.5.1
  • @patternfly/react-table@2.14.2
  • @patternfly/react-topology@2.5.9
  • @patternfly/react-virtualized-extension@1.1.61
  • @patternfly/react-icons@3.10.9

Thanks for your contribution! 🎉

@redallen redallen deleted the fix/windows branch Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.