Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ChartDonut): Replaced prop `titleComponent` by `subTitleComponent` #2488

Merged
merged 1 commit into from Jul 10, 2019

Conversation

@bond95
Copy link
Contributor

bond95 commented Jul 9, 2019

Previously ChartDonut component (in patternfly 4) for building subTitle used prop titleComponent, while prop
subTitleComponent was unused. So in this PR titleComponent in getSubtitle was replaced by
subTitleComponent.

fix #2486

…tle` by `subTitleComponent`.

Previously `ChartDonut` component for building `subTitle` used prop `titleComponent`, while prop
`subTitleComponent` was unused. So in this PR `titleComponent` in `getSubtitle` was replaced by
`subTitleComponent`.

fix #2486
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jul 9, 2019

PatternFly-React preview: https://patternfly-react-pr-2488.surge.sh

@tlabaj tlabaj requested a review from dlabrecq Jul 9, 2019
@tlabaj
tlabaj approved these changes Jul 10, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj merged commit 18190a4 into patternfly:master Jul 10, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jul 10, 2019

Your changes have been released in:

  • @patternfly/react-charts@4.4.17

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.