Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ApplicationLauncher): Allow custom icon for application launcher toggle #2492

Merged
merged 1 commit into from Jul 10, 2019

Conversation

@jeff-phillips-18
Copy link
Member

jeff-phillips-18 commented Jul 9, 2019

What:
Accept a prop (toggleIcon) to allow overriding the application launcher's toggle icon.

Copy link
Contributor

redallen left a comment

CI failed rendering ApplicationLauncher.md:

@patternfly/react-docs: error Building static HTML failed for path "/components/applicationlauncher/"
@patternfly/react-docs: See our docs page on debugging HTML builds for help https://gatsby.dev/debug-html
@patternfly/react-docs:   2948 |   });
@patternfly/react-docs:   2949 |   // eslint-disable-next-line no-new-func
@patternfly/react-docs: > 2950 |   var res = new (Function.prototype.bind.apply(Function, [null].concat(['_poly', 'React'], scopeKeys, [code])))();
@patternfly/react-docs:        | ^
@patternfly/react-docs:   2951 |   return res.apply(undefined, [_poly, React].concat(scopeValues));
@patternfly/react-docs:   2952 | };
@patternfly/react-docs:   2953 | 
@patternfly/react-docs: 
@patternfly/react-docs:   WebpackError: ReferenceError: HelpIcon is not defined
@patternfly/react-docs:   
@patternfly/react-docs:   - react-live.es.js:2950 ApplicationLauncheIcon.render
@patternfly/react-docs:     [project]/[react-live]/dist/react-live.es.js:2950:1
@jeff-phillips-18 jeff-phillips-18 force-pushed the jeff-phillips-18:app-launcher branch from b4a832c to 1088eed Jul 9, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jul 9, 2019

PatternFly-React preview: https://patternfly-react-pr-2492.surge.sh

@jeff-phillips-18

This comment has been minimized.

Copy link
Member Author

jeff-phillips-18 commented Jul 9, 2019

@redallen Fixed the CI issue.

Copy link
Contributor

redallen left a comment

Good fix :)

@jschuler jschuler merged commit 9cdc85d into patternfly:master Jul 10, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jul 10, 2019

Your changes have been released in:

  • @patternfly/react-core@3.67.4
  • @patternfly/react-docs@4.8.70
  • @patternfly/react-inline-edit-extension@2.9.33
  • demo-app-ts@2.8.4
  • @patternfly/react-table@2.14.7
  • @patternfly/react-topology@2.6.4
  • @patternfly/react-virtualized-extension@1.1.66

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.