Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Tabs): Allow eventKey to accept a string #2493

Merged
merged 4 commits into from Jul 10, 2019

Conversation

@tlabaj
Copy link
Contributor

tlabaj commented Jul 10, 2019

#1446

What:

Additional issues:

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jul 10, 2019

PatternFly-React preview: https://patternfly-react-pr-2493.surge.sh

Copy link
Contributor

dlabaj left a comment

LGTM.

Titani
@tlabaj tlabaj dismissed stale reviews from dlabaj and dlabrecq via 08513da Jul 10, 2019
Titani
Titani
Copy link
Member

rebeccaalpert left a comment

Looks great!

@dlabaj
dlabaj approved these changes Jul 10, 2019
@dlabaj dlabaj merged commit 1bde27c into patternfly:master Jul 10, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.