Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(EmptyState): update EmptyStateBody to use <div> instead of <p> #2499

Merged
merged 2 commits into from Jul 12, 2019

Conversation

@tlabaj
Copy link
Contributor

tlabaj commented Jul 10, 2019

#2494

What:

Additional issues:

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jul 11, 2019

PatternFly-React preview: https://patternfly-react-pr-2499.surge.sh

@tlabaj tlabaj added the css review label Jul 11, 2019
@tlabaj tlabaj requested a review from mcoker Jul 11, 2019
Copy link
Contributor

mcoker left a comment

thanks!

Titani
@tlabaj tlabaj dismissed stale reviews from mcoker and boaz0 via 0f42a23 Jul 11, 2019
Copy link
Member

rebeccaalpert left a comment

Looks good to me.

@jschuler jschuler merged commit 233fe25 into patternfly:master Jul 12, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jul 12, 2019

Your changes have been released in:

  • @patternfly/react-core@3.72.0
  • @patternfly/react-docs@4.8.76
  • @patternfly/react-inline-edit-extension@2.9.39
  • demo-app-ts@2.12.1
  • @patternfly/react-table@2.14.13
  • @patternfly/react-topology@2.6.10
  • @patternfly/react-virtualized-extension@1.1.72

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.