Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Dropdown): Convert dropdown to typescript #2502

Merged
merged 11 commits into from Jul 25, 2019

Conversation

@jessiehuff
Copy link
Contributor

jessiehuff commented Jul 11, 2019

Fixes #2209

Jessie added 3 commits Jul 12, 2019
Jessie
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jul 15, 2019

PatternFly-React preview: https://patternfly-react-pr-2502.surge.sh

Jessie added 2 commits Jul 15, 2019
Jessie
Jessie
@dlabrecq

This comment has been minimized.

Copy link
Member

dlabrecq commented Jul 18, 2019

Probably good to run these changes though a product UI first (e.g., Cost Management), to ensure the type changes work properly. I have doubts that HTMLElement is the correct type for parentRef?

Jessie
Jessie
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jul 22, 2019

PatternFly-React preview: https://patternfly-react-pr-2502.surge.sh

Copy link
Member

dlabrecq left a comment

Built the source locally and tested with Cost Management. The build is working now with the latest changes.

We don't use parentRef, but is pagination working as expected -- don't see any errors in the browser console.

@boaz0
boaz0 approved these changes Jul 24, 2019
@redallen redallen merged commit 14474fe into patternfly:master Jul 25, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jul 25, 2019

Your changes have been released in:

  • @patternfly/react-core@3.77.0
  • @patternfly/react-docs@4.9.5
  • @patternfly/react-inline-edit-extension@2.9.52
  • demo-app-ts@2.13.0
  • @patternfly/react-integration@2.13.0
  • @patternfly/react-table@2.15.0
  • @patternfly/react-topology@2.7.1
  • @patternfly/react-virtualized-extension@1.1.85

Thanks for your contribution! 🎉

@priley86

This comment has been minimized.

Copy link
Member

priley86 commented Jul 25, 2019

thanks @jessiehuff ! definitely needed this for the Table conversion in #2360. Will try and rebase this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.