Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): remove tippy-react dependency #2505

Merged
merged 1 commit into from Jul 18, 2019

Conversation

@seanforyou23
Copy link
Member

seanforyou23 commented Jul 12, 2019

What: This PR removes the dependency on @tippy.js/react and brings this functionality in-house as a new helper component called PopoverBase. We ran into issues with the latest version of @tippy.js/react (2.x) and decided that best path forward for us is bringing this module in-house. Of course, we're still using tippy.js core so we're basically swapping @tippy.js/react for tippy.js as a dependency.

Additional issues: N/A

This is the first of putting back into place work that was abandoned in #2326 and #2395

There will be follow up PR's for the remaining work - will link them together in the descriptions for easy tracking.

@seanforyou23 seanforyou23 added the PF4 label Jul 12, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jul 12, 2019

PatternFly-React preview: https://patternfly-react-pr-2505.surge.sh

@seanforyou23 seanforyou23 force-pushed the seanforyou23:tooltip-popover-refactor branch from 0aabd74 to 6e3947a Jul 12, 2019
Copy link
Contributor

redallen left a comment

Thanks!

@seanforyou23 seanforyou23 requested a review from redallen Jul 16, 2019
@seanforyou23 seanforyou23 force-pushed the seanforyou23:tooltip-popover-refactor branch from 6e3947a to 088794a Jul 16, 2019
@seanforyou23 seanforyou23 force-pushed the seanforyou23:tooltip-popover-refactor branch from 088794a to 9c14c21 Jul 17, 2019
@seanforyou23 seanforyou23 requested a review from redallen Jul 17, 2019
@seanforyou23 seanforyou23 requested a review from dlabrecq Jul 17, 2019
@jschuler jschuler merged commit c9e87a6 into patternfly:master Jul 18, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jul 18, 2019

Your changes have been released in:

  • @patternfly/react-core@3.73.1
  • @patternfly/react-docs@4.8.81
  • @patternfly/react-inline-edit-extension@2.9.44
  • demo-app-ts@2.12.6
  • @patternfly/react-table@2.14.18
  • @patternfly/react-topology@2.6.15
  • @patternfly/react-virtualized-extension@1.1.77

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.