Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(charts): tweak aria title for area chart #2510

Merged
merged 1 commit into from Jul 15, 2019

Conversation

@dlabrecq
Copy link
Member

dlabrecq commented Jul 12, 2019

Simple fix for the area chart examples.

ariaTitle="Donut chart example"

should be:

ariaTitle="Area chart example"

Fixes #2509

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jul 12, 2019

PatternFly-React preview: https://patternfly-react-pr-2510.surge.sh

@tlabaj tlabaj requested review from mattnolting and jschuler Jul 15, 2019
@tlabaj
tlabaj approved these changes Jul 15, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj added the PF4 label Jul 15, 2019
@tlabaj tlabaj self-assigned this Jul 15, 2019
Copy link
Contributor

mattnolting left a comment

👍 LGTM!

@jschuler jschuler merged commit 40197a2 into patternfly:master Jul 15, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@dlabrecq dlabrecq deleted the dlabrecq:2509-area-chart-example branch Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.