Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Tabs): Implement overflow styles for secondary tabs #2512

Merged
merged 4 commits into from Jul 17, 2019

Conversation

@jessiehuff
Copy link
Contributor

jessiehuff commented Jul 12, 2019

Fixes #1705

Jessie
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jul 12, 2019

PatternFly-React preview: https://patternfly-react-pr-2512.surge.sh

@tlabaj tlabaj removed the current sprint label Jul 12, 2019
@tlabaj tlabaj requested a review from jschuler Jul 12, 2019
@tlabaj tlabaj added the css review label Jul 12, 2019
@tlabaj tlabaj requested a review from mcoker Jul 12, 2019
Jessie
Copy link
Contributor

mcoker left a comment

Left a comment about sentence case, but otherwise LGTM!! Nice job @jessiehuff!!

Jessie
Jessie
Copy link
Collaborator

jschuler left a comment

Looks good!

@redallen redallen merged commit d840c4d into patternfly:master Jul 17, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jul 17, 2019

Your changes have been released in:

  • @patternfly/react-core@3.73.0
  • @patternfly/react-docs@4.8.80
  • @patternfly/react-inline-edit-extension@2.9.43
  • demo-app-ts@2.12.5
  • @patternfly/react-table@2.14.17
  • @patternfly/react-topology@2.6.14
  • @patternfly/react-virtualized-extension@1.1.76

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.