Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
fix(options menu): update examples to trigger select on the whole item #2513
What: need feedback on these changes -- this WIP PR is in reference to #2415. Currently, the new click event handler I added seems to work fine on the first three options menu demos, where you can click anywhere on the item to select/deselect it.
However, the last three demos don't seem to work with this new prop, and when you click directly on the check mark of an item that's been selected, it still doesn't deselect the item.
Why would this be happening?
jschuler left a comment
Hi @jenny-s51 , thank you for taking a look at this! I think the issue here is actually simpler, in the consumer onSelect callback function in OptionsMenu.md, we just simply have to change
Your changes have been released in:
Thanks for your contribution!