Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dropdown): adds aria-label for icon only example #2517

Merged
merged 1 commit into from Jul 29, 2019

Conversation

@jenny-s51
Copy link
Contributor

jenny-s51 commented Jul 15, 2019

What: Closes #1837. It appears that list item 1 of this issue has already been addressed, and an aria label already exists on the kebab example of dropdown. This PR adds an aria-label to the "icon only" example of Dropdown.

@jenny-s51 jenny-s51 requested a review from jgiardino Jul 15, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jul 15, 2019

PatternFly-React preview: https://patternfly-react-pr-2517.surge.sh

@tlabaj tlabaj self-requested a review Jul 15, 2019
@tlabaj tlabaj self-assigned this Jul 15, 2019
Copy link
Collaborator

jgiardino left a comment

These updates look good and work as expected! Thanks!

I did notice that the prop type for aria-label on DropdownToggle changed from string to any, so just want to mention that in case it wasn't intentional. I also noticed that we don't list props for KebabToggle on the Dropdown example, but that was before this PR, and just want to mention that in case we need to add an issue for that.

@tlabaj
tlabaj approved these changes Jul 29, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj merged commit dd2dc02 into patternfly:master Jul 29, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@jenny-s51 jenny-s51 deleted the jenny-s51:iss1837 branch Aug 6, 2019
@jenny-s51 jenny-s51 restored the jenny-s51:iss1837 branch Aug 12, 2019
@jenny-s51 jenny-s51 deleted the jenny-s51:iss1837 branch Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.