Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Select): update typeahead filtered list when children change #2518

Merged
merged 1 commit into from Jul 22, 2019

Conversation

@kmcfaul
Copy link
Contributor

kmcfaul commented Jul 15, 2019

What: Fixes typeahead select children not updating properly when children is changed.

Refer to issue: #2090

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jul 15, 2019

PatternFly-React preview: https://patternfly-react-pr-2518.surge.sh

@tlabaj
tlabaj approved these changes Jul 15, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj self-assigned this Jul 15, 2019
@tlabaj tlabaj requested a review from jschuler Jul 15, 2019
@redallen redallen merged commit 85562fe into patternfly:master Jul 22, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.