Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add individual padding vars for donut charts #2529

Merged
merged 1 commit into from Jul 18, 2019

Conversation

@dlabrecq
Copy link
Member

dlabrecq commented Jul 16, 2019

Added individual padding vars in pf-core for each donut chart. (Currently, the donut charts inherit the pie chart's padding property.) That will ensure changes, to the pie chart padding property, do not inadvertently break donut charts.

Also ensured that the donut size is always the minimum of height / width (default) and the donutHeight / donutWidth props. Thus, eliminating the potential to cause layout issues depending on the order in which properties are set.

Minor clean up to docs, etc.

Fixes #2528

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jul 17, 2019

PatternFly-React preview: https://patternfly-react-pr-2529.surge.sh

@dlabrecq dlabrecq force-pushed the dlabrecq:2528-donut-chart-vars branch 8 times, most recently from ba6c561 to b0d05d9 Jul 17, 2019
@dlabrecq dlabrecq marked this pull request as ready for review Jul 17, 2019
@dlabrecq dlabrecq force-pushed the dlabrecq:2528-donut-chart-vars branch from b0d05d9 to 6f81b28 Jul 17, 2019
@dlabrecq dlabrecq force-pushed the dlabrecq:2528-donut-chart-vars branch from 6f81b28 to aefd262 Jul 17, 2019
@dlabrecq dlabrecq force-pushed the dlabrecq:2528-donut-chart-vars branch from aefd262 to 6174c09 Jul 17, 2019
@jschuler jschuler merged commit 771eee8 into patternfly:master Jul 18, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jul 18, 2019

Your changes have been released in:

  • @patternfly/react-charts@4.6.4

Thanks for your contribution! 🎉

@dlabrecq dlabrecq deleted the dlabrecq:2528-donut-chart-vars branch Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.