Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Tooltip): Added support for aria prop from Tippy library #2539

Merged
merged 1 commit into from Jul 25, 2019

Conversation

@rebeccaalpert
Copy link
Member

rebeccaalpert commented Jul 18, 2019

Added aria prop for aria-describedby or aria-labelledby support from the Tippy library. Default is library default.

Fixes #1458.

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jul 18, 2019

PatternFly-React preview: https://patternfly-react-pr-2539.surge.sh

@rebeccaalpert rebeccaalpert force-pushed the rebeccaalpert:tooltip-aria branch 2 times, most recently from 85499f6 to 7a5b4e5 Jul 18, 2019
@redallen

This comment has been minimized.

Copy link
Contributor

redallen commented Jul 22, 2019

@rebeccaalpert Conflicts :(

@rebeccaalpert rebeccaalpert force-pushed the rebeccaalpert:tooltip-aria branch from 7a5b4e5 to 89f828e Jul 22, 2019
@rebeccaalpert rebeccaalpert force-pushed the rebeccaalpert:tooltip-aria branch from 89f828e to aeaac94 Jul 22, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jul 22, 2019

PatternFly-React preview: https://patternfly-react-pr-2539.surge.sh

Copy link
Contributor

redallen left a comment

Could be a bool, but this I like the explicitness.

@redallen redallen merged commit 54dce53 into patternfly:master Jul 25, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jul 25, 2019

Your changes have been released in:

  • @patternfly/react-core@3.76.0
  • @patternfly/react-docs@4.9.4
  • @patternfly/react-inline-edit-extension@2.9.51
  • demo-app-ts@2.12.13
  • @patternfly/react-table@2.14.25
  • @patternfly/react-topology@2.7.0
  • @patternfly/react-virtualized-extension@1.1.84

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.