Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(charts): added new mutil-color theme for ordered charts #2552

Merged
merged 2 commits into from Jul 22, 2019

Conversation

@dlabrecq
Copy link
Member

dlabrecq commented Jul 19, 2019

Created a new, mutil-color theme specifically for ordered charts; donut, pie, bar, & stack. The existing multi-color theme will continue to be used for unordered charts; area & line.

To avoid a breaking change, ChartThemeColor.multi defaults to the ChartThemeColor.multiOrdered theme, since area/line are the only unordered charts.

Fixes #2550

Screen Shot 2019-07-19 at 12 12 05 PM

Screen Shot 2019-07-19 at 12 12 15 PM

Screen Shot 2019-07-19 at 1 01 10 PM

Screen Shot 2019-07-19 at 1 01 01 PM

Screen Shot 2019-07-19 at 12 12 51 PM

Screen Shot 2019-07-19 at 12 12 31 PM

@dlabrecq dlabrecq requested a review from AllenBW Jul 19, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jul 19, 2019

PatternFly-React preview: https://patternfly-react-pr-2552.surge.sh

@dlabrecq dlabrecq force-pushed the dlabrecq:2550-multi-ordered-theme branch from c4e670a to b6be1c0 Jul 19, 2019
@dlabrecq dlabrecq requested a review from mceledonia Jul 19, 2019
@dlabrecq dlabrecq force-pushed the dlabrecq:2550-multi-ordered-theme branch from b6be1c0 to aaca061 Jul 19, 2019
@AllenBW

This comment has been minimized.

Copy link
Contributor

AllenBW commented Jul 19, 2019

read my mind, documentation for ordered and un <3

Copy link
Contributor

AllenBW left a comment

FANTASTIC!! Just what the 👩‍⚕ ordered (ordered 😏 )

Copy link

mceledonia left a comment

Looks great, thanks Dan!

Copy link
Contributor

redallen left a comment

I like purple, but it's true the contrast with blue isn't that great 👍

@dlabrecq dlabrecq merged commit 8ab3844 into patternfly:master Jul 22, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jul 22, 2019

Your changes have been released in:

  • @patternfly/react-charts@4.7.0
  • @patternfly/react-core@3.74.0
  • @patternfly/react-docs@4.8.83
  • @patternfly/react-inline-edit-extension@2.9.46
  • demo-app-ts@2.12.8
  • @patternfly/react-table@2.14.20
  • @patternfly/react-topology@2.6.17
  • @patternfly/react-virtualized-extension@1.1.79

Thanks for your contribution! 🎉

@priley86 priley86 mentioned this pull request Jul 23, 2019
4 of 4 tasks complete
@priley86

This comment has been minimized.

Copy link
Member

priley86 commented Jul 23, 2019

thanks for this contribution @dlabrecq ! I don't think we'll have a chance to pull this in immediately in Subscriptions, but we've filed an issue today:
RedHatInsights/curiosity-frontend#51

Will bounce back if I have any problems!

@dlabrecq dlabrecq deleted the dlabrecq:2550-multi-ordered-theme branch Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.