Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-table): Add exports for compoundExpand. #2554

Merged
merged 1 commit into from Jul 22, 2019

Conversation

@jcaianirh
Copy link
Contributor

jcaianirh commented Jul 19, 2019

What: Fix for issue: #1657

Additional issues:

Add exports for compoundExpand.

@jcaianirh jcaianirh force-pushed the jcaianirh:issue-1657 branch from 7fadd36 to 03d3bf3 Jul 19, 2019
@jcaianirh jcaianirh changed the title Add exports for compoundExpand. fix(react-table): Add exports for compoundExpand. Jul 19, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jul 19, 2019

PatternFly-React preview: https://patternfly-react-pr-2554.surge.sh

@@ -19,5 +19,5 @@ export { default as TableHeader, HeaderProps } from './Header';
export { default as TableBody, TableBodyProps } from './Body';
export { default as RowWrapper, RowWrapperRow, RowWrapperProps } from './RowWrapper';
export { default as ExpandableRowContent } from './ExpandableRowContent';
export { sortable, headerCol, cellWidth, ISortable, expandable, isRowExpanded } from './utils';
export { sortable, headerCol, cellWidth, ISortable, expandable, isRowExpanded, compoundExpand } from './utils';

This comment has been minimized.

Copy link
@redallen

redallen Jul 22, 2019

Contributor

This seems close to export * from './utils';

Either way, the TS conversion in #2360 will eventually resolve this too.

This comment has been minimized.

Copy link
@priley86

priley86 Jul 22, 2019

Member

+1... i am planning to circle back and ensure we can do export * on all exports, and that they are converted from default exports to named exports... will probably attempt this towards the end to be certain. I've gone ahead and rebased this change for now though!

@redallen redallen merged commit 6cdd352 into patternfly:master Jul 22, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.