Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): select menu has consistent behavior on input field #2572

Merged
merged 5 commits into from Jul 25, 2019

Conversation

@jenny-s51
Copy link
Contributor

jenny-s51 commented Jul 23, 2019

What: Closes #2561. Select menu now has consistent, open behavior on empty text input field. This is the expected default behavior per @mcarrano's feedback.

@jenny-s51 jenny-s51 requested review from mcarrano, tlabaj and kmcfaul Jul 23, 2019
@jenny-s51 jenny-s51 self-assigned this Jul 23, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jul 23, 2019

PatternFly-React preview: https://patternfly-react-pr-2572.surge.sh

Copy link
Contributor

redallen left a comment

Works when I tab to it and makes sense.

Copy link
Member

mcarrano left a comment

@jenny-s51 I still am having problems getting the text insertion cursor when I click on the input field for type-ahead select.

@jenny-s51

This comment has been minimized.

Copy link
Contributor Author

jenny-s51 commented Jul 24, 2019

@mcarrano this is because the react workspace is currently using an outdated version of core. The input field issue was fixed here by @mcoker patternfly/patternfly-next#2075, and is in a newer core release. As soon as @redallen 's PR #2549 is merged, the input field will work as expected.

@jenny-s51 jenny-s51 requested a review from mcarrano Jul 24, 2019
@jenny-s51 jenny-s51 dismissed mcarrano’s stale review Jul 25, 2019

Version bump has been merged.

Copy link
Member

mcarrano left a comment

@mcarrano mcarrano added ux approved and removed ux review labels Jul 25, 2019
@redallen redallen merged commit f26c530 into patternfly:master Jul 25, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jul 25, 2019

Your changes have been released in:

  • @patternfly/react-core@3.77.1
  • @patternfly/react-docs@4.9.6
  • @patternfly/react-inline-edit-extension@2.9.53
  • demo-app-ts@2.13.1
  • @patternfly/react-table@2.15.1
  • @patternfly/react-topology@2.7.2
  • @patternfly/react-virtualized-extension@1.1.86

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.