Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chart): ensure dynamic chart size is never less than zero #2590

Merged
merged 1 commit into from Jul 25, 2019

Conversation

@dlabrecq
Copy link
Member

dlabrecq commented Jul 25, 2019

The donut threshold chart generates a 'width must be a non-negative' warning when donutWidth values are zero.

This change ensures the dynamic chart size is never less than zero.

Fixes #2587

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jul 25, 2019

PatternFly-React preview: https://patternfly-react-pr-2590.surge.sh

@dlabaj
dlabaj approved these changes Jul 25, 2019
@dlabaj dlabaj merged commit 9e9b48e into patternfly:master Jul 25, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@dlabrecq dlabrecq deleted the dlabrecq:2587-donut-warning branch Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.