Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Pagination): add a demo of table integrated with pagination #2601

Merged
merged 1 commit into from Jul 30, 2019

Conversation

@boaz0
Copy link
Member

boaz0 commented Jul 29, 2019

What:

closes #2337

Added a working demo/example of pagination and table components.

//cc @tlabaj @jamesla

Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jul 29, 2019

PatternFly-React preview: https://patternfly-react-pr-2601.surge.sh

@dlabaj
dlabaj approved these changes Jul 29, 2019
@tlabaj
tlabaj approved these changes Jul 30, 2019
Copy link
Contributor

tlabaj left a comment

Looks great!

@tlabaj tlabaj merged commit 36b9c84 into patternfly:master Jul 30, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@boaz0

This comment has been minimized.

Copy link
Member Author

boaz0 commented Jul 30, 2019

Thank you all @dlabaj @tlabaj

@boaz0 boaz0 deleted the boaz0:closes_2337 branch Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.