Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Select): adds direction prop to Select #2611

Merged
merged 4 commits into from Aug 19, 2019

Conversation

@kmcfaul
Copy link
Contributor

kmcfaul commented Jul 30, 2019

What: Allows user to specify the direction of the Select's menu expansion. Adds a SelectDirection enum for explicit directions.

Refer to issue: #2368

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jul 30, 2019

PatternFly-React preview: https://patternfly-react-pr-2611.surge.sh

@tlabaj tlabaj added the css review label Aug 1, 2019
@tlabaj tlabaj requested review from mcoker and tlabaj Aug 1, 2019
Copy link
Contributor

tlabaj left a comment

I would also add this ti the integration app to verify prop works with no errors.

@kmcfaul kmcfaul force-pushed the kmcfaul:select-direction branch from 84891e8 to da4f320 Aug 19, 2019
Copy link
Contributor

redallen left a comment

LGTM

Copy link
Collaborator

jschuler left a comment

Since we have the enum we should use it consistently :)

@redallen redallen dismissed tlabaj’s stale review Aug 19, 2019

Demo has been added.

@redallen redallen merged commit f192742 into patternfly:master Aug 19, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Aug 19, 2019

Your changes have been released in:

  • @patternfly/react-core@3.88.0
  • @patternfly/react-docs@4.10.12
  • @patternfly/react-inline-edit-extension@2.10.8
  • demo-app-ts@2.20.0
  • @patternfly/react-integration@2.20.0
  • @patternfly/react-table@2.18.2
  • @patternfly/react-topology@2.7.33
  • @patternfly/react-virtualized-extension@1.1.119

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.