Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Select): Adds the ability to pass in a user defined object #2612

Merged
merged 5 commits into from Aug 8, 2019

Conversation

@dlabaj
Copy link
Contributor

dlabaj commented Jul 30, 2019

This enhancement allows a user to now pass in a user defined object to store additional data besides just the string value to a select option. The object must have a toString function that is
responsible for returning the the localized string.

fix #2045

What:

Additional issues:

@dlabaj dlabaj requested review from jschuler, tlabaj and kmcfaul Jul 30, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jul 30, 2019

PatternFly-React preview: https://patternfly-react-pr-2612.surge.sh

@dlabaj dlabaj added the PF4 label Jul 30, 2019
Copy link
Contributor

tlabaj left a comment

Can you please add a demo for this and some test.

@kmcfaul

This comment has been minimized.

Copy link
Contributor

kmcfaul commented Jul 30, 2019

Echoing adding the tests, otherwise looks great

dlabaj added 3 commits Jul 30, 2019
…s a value.

This enhancement allows a user to now pass in a user defined object to store additional data besides
just the string value to a select option.  The object must have a toString function that is
responsible for returning the the localized string.

fix #2045
@dlabaj dlabaj force-pushed the dlabaj:issue-2045 branch from 823661f to 138c3fe Aug 6, 2019
@kmcfaul
kmcfaul approved these changes Aug 8, 2019
@tlabaj
tlabaj approved these changes Aug 8, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj merged commit 9037033 into patternfly:master Aug 8, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Aug 8, 2019

Your changes have been released in:

  • @patternfly/react-core@3.83.0
  • @patternfly/react-docs@4.9.25
  • @patternfly/react-inline-edit-extension@2.9.70
  • demo-app-ts@2.16.0
  • @patternfly/react-integration@2.16.0
  • @patternfly/react-table@2.16.9
  • @patternfly/react-topology@2.7.18
  • @patternfly/react-virtualized-extension@1.1.104

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.