Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(button): add 'reset' to types #2622

Merged
merged 2 commits into from Aug 1, 2019
Merged

Conversation

@redallen
Copy link
Contributor

redallen commented Jul 31, 2019

Fixes #2391

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jul 31, 2019

PatternFly-React preview: https://patternfly-react-pr-2622.surge.sh

@kmcfaul

This comment has been minimized.

Copy link
Contributor

kmcfaul commented Aug 1, 2019

Looks good but tests need to be updated.

@kmcfaul
kmcfaul approved these changes Aug 1, 2019
@redallen redallen merged commit 8ee40c0 into patternfly:master Aug 1, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Aug 1, 2019

Your changes have been released in:

  • @patternfly/react-core@3.80.3
  • @patternfly/react-docs@4.9.14
  • @patternfly/react-inline-edit-extension@2.9.60
  • demo-app-ts@2.14.4
  • @patternfly/react-integration@2.14.1
  • @patternfly/react-table@2.16.0
  • @patternfly/react-topology@2.7.9
  • @patternfly/react-virtualized-extension@1.1.93

Thanks for your contribution! 🎉

@tlabaj

This comment has been minimized.

Copy link
Contributor

tlabaj commented Aug 6, 2019

@jessiehuff @kmcfaul @redallen This pr needed a css review.

@tlabaj

This comment has been minimized.

Copy link
Contributor

tlabaj commented Aug 6, 2019

@christiemolloy can you look at this one and verify everything is as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.