Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Chart Themes): Fix missing fill and stroke colors for area and line charts #2626

Merged
merged 1 commit into from Aug 2, 2019

Conversation

@TheRealJon
Copy link
Contributor

TheRealJon commented Aug 1, 2019

fix #2624

What:

  • Set area.style.data.fill to first color scale value in colorTheme function.
  • Set line.style.data.stroke to first color scale value in colorTheme function
…ne charts

Data fill and stroke colors were not being set in 'colorTheme' helper function for area and line
charts.

fix #2624
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Aug 1, 2019

PatternFly-React preview: https://patternfly-react-pr-2626.surge.sh

@TheRealJon TheRealJon requested a review from dlabrecq Aug 1, 2019
Copy link
Member

dlabrecq left a comment

Looks good.

FYI, Select.test.tsx.snap was also updated. Although, the build seems ok

@TheRealJon TheRealJon requested a review from dlabaj Aug 1, 2019
@tlabaj
tlabaj approved these changes Aug 2, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj merged commit 9d3138c into patternfly:master Aug 2, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@TheRealJon TheRealJon deleted the TheRealJon:2624-github branch Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.