Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Pagination): Fix pagination to update page count #2639

Merged
merged 4 commits into from Aug 6, 2019

Conversation

@jessiehuff
Copy link
Contributor

jessiehuff commented Aug 5, 2019

Fixes #2629

Jessie added 2 commits Aug 5, 2019
Jessie
Jessie
AllenBW added a commit to AllenBW/insights-advisor-frontend that referenced this pull request Aug 5, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Aug 5, 2019

PatternFly-React preview: https://patternfly-react-pr-2639.surge.sh

@AllenBW

This comment has been minimized.

Copy link
Contributor

AllenBW commented Aug 5, 2019

The only issue with this is... now yah can't change the date via input :(

@jessiehuff

This comment has been minimized.

Copy link
Contributor Author

jessiehuff commented Aug 5, 2019

@AllenBW I was trying to look into this, but I'm not positive I know what you mean. Can you explain further or show me what's happening for you? I'll definitely work on whatever is going on! :)

@AllenBW

This comment has been minimized.

Copy link
Contributor

AllenBW commented Aug 5, 2019

@jessiehuff hi!! I believe its the same issue we see in the test failure, if i drop into the PatternFly-React preview and attempt to change the page via the input (rather than the flanking page buttons) there is no change in page value 😬

@AllenBW

This comment has been minimized.

Copy link
Contributor

AllenBW commented Aug 5, 2019

#2417 Is definitely the work that resulted in this issue, another fe (in addition to insights) that demonstrates this issue is https://cloud.redhat.com/beta/rhel/vulnerability/cves so you'll update the top pagination and the bottom one will not reflect the changes

AllenBW added a commit to RedHatInsights/insights-advisor-frontend that referenced this pull request Aug 5, 2019
ryelo pushed a commit to RedHatInsights/insights-advisor-frontend-build that referenced this pull request Aug 5, 2019
ryelo pushed a commit to RedHatInsights/insights-advisor-frontend-build that referenced this pull request Aug 5, 2019
ryelo pushed a commit to RedHatInsights/insights-advisor-frontend-build that referenced this pull request Aug 5, 2019
@dlabaj dlabaj requested review from redallen, rebeccaalpert and tlabaj Aug 5, 2019
@dlabaj dlabaj added the PF4 label Aug 5, 2019
Copy link
Contributor

dlabaj left a comment

@jessiehuff Looks like the jest tests are failing.

AllenBW added a commit to AllenBW/insights-advisor-frontend that referenced this pull request Aug 5, 2019
Jessie added 2 commits Aug 5, 2019
Jessie
@jessiehuff

This comment has been minimized.

Copy link
Contributor Author

jessiehuff commented Aug 5, 2019

Hey @AllenBW! I think I got it figured out. :) Sorry it took me so long, I had issues with my development environment that I had to solve first haha. Thanks for pointing out the issue!

@AllenBW

This comment has been minimized.

Copy link
Contributor

AllenBW commented Aug 5, 2019

WOOHOO!! thanks for effort! lookin forward to incorporating this fix 😋 💃🏾🌺

@dlabaj
dlabaj approved these changes Aug 6, 2019
@dlabaj dlabaj merged commit ff9c745 into patternfly:master Aug 6, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Aug 6, 2019

Your changes have been released in:

  • @patternfly/react-core@3.82.2
  • @patternfly/react-docs@4.9.21
  • @patternfly/react-inline-edit-extension@2.9.66
  • demo-app-ts@2.15.2
  • @patternfly/react-table@2.16.6
  • @patternfly/react-topology@2.7.15
  • @patternfly/react-virtualized-extension@1.1.100

Thanks for your contribution! 🎉

AllenBW added a commit to AllenBW/insights-advisor-frontend that referenced this pull request Aug 6, 2019
AllenBW added a commit to RedHatInsights/insights-advisor-frontend that referenced this pull request Aug 6, 2019
ryelo pushed a commit to RedHatInsights/insights-advisor-frontend-build that referenced this pull request Aug 6, 2019
ryelo pushed a commit to RedHatInsights/insights-advisor-frontend-build that referenced this pull request Aug 6, 2019
ryelo pushed a commit to RedHatInsights/insights-advisor-frontend-build that referenced this pull request Aug 6, 2019
ryelo pushed a commit to RedHatInsights/insights-advisor-frontend-build that referenced this pull request Aug 6, 2019
ryelo pushed a commit to RedHatInsights/insights-advisor-frontend-build that referenced this pull request Aug 6, 2019
ryelo pushed a commit to RedHatInsights/insights-advisor-frontend-build that referenced this pull request Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.