Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(table): replace lodash-es with lodash #2641

Merged
merged 1 commit into from Aug 5, 2019

Conversation

@redallen
Copy link
Contributor

redallen commented Aug 5, 2019

What: Fixes #2617 Fixes #2616

Additional issues:

@redallen redallen requested a review from priley86 Aug 5, 2019
@@ -40,7 +40,6 @@
},
"peerDependencies": {
"@patternfly/react-table": "^2.10.0",
"lodash-es": "4.x",

This comment has been minimized.

Copy link
@priley86

priley86 Aug 5, 2019

Member

should lodash be added as a peerDependency now?

This comment has been minimized.

Copy link
@redallen

redallen Aug 5, 2019

Author Contributor

react-virtualized-extension doesn't use lodash-es anywhere.

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Aug 5, 2019

PatternFly-React preview: https://patternfly-react-pr-2641.surge.sh

@priley86

This comment has been minimized.

Copy link
Member

priley86 commented Aug 5, 2019

this is nearly identical to #2640 now... let's pick one 😄

@aljesusg

This comment has been minimized.

Copy link
Contributor

aljesusg commented Aug 5, 2019

This Fix #2616 too.

@jschuler jschuler merged commit ad3ccc8 into patternfly:master Aug 5, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@aljesusg

This comment has been minimized.

Copy link
Contributor

aljesusg commented Aug 5, 2019

Hooray !!! Thanks

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Aug 5, 2019

Your changes have been released in:

  • @patternfly/react-docs@4.9.18
  • @patternfly/react-inline-edit-extension@2.9.64
  • @patternfly/react-table@2.16.4
  • @patternfly/react-virtualized-extension@1.1.97

Thanks for your contribution! 🎉

@aljesusg aljesusg mentioned this pull request Aug 5, 2019
7 of 7 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.