Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Alert): Add the default alert variant #2648

Merged
merged 3 commits into from Aug 6, 2019

Conversation

@tlabaj
Copy link
Contributor

tlabaj commented Aug 5, 2019

What: Add default variant for Alert.

Additional issues:
#2596

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Aug 5, 2019

PatternFly-React preview: https://patternfly-react-pr-2648.surge.sh

Copy link
Member

mcarrano left a comment

Looks good to me. Thanks, @tlabaj !

@mcarrano mcarrano added ux approved and removed ux review labels Aug 6, 2019
Titani
@kmcfaul
kmcfaul approved these changes Aug 6, 2019
@dlabaj
dlabaj approved these changes Aug 6, 2019
@@ -10,13 +10,14 @@ export enum AlertVariant {
success = 'success',
danger = 'danger',
warning = 'warning',
info = 'info'
info = 'info',

This comment has been minimized.

Copy link
@dlabaj

dlabaj Aug 6, 2019

Contributor

feel like these should be in alphabetical order ...

@dlabaj dlabaj merged commit 322a242 into patternfly:master Aug 6, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Aug 6, 2019

Your changes have been released in:

  • @patternfly/react-core@3.82.3
  • @patternfly/react-docs@4.9.22
  • @patternfly/react-inline-edit-extension@2.9.67
  • demo-app-ts@2.15.3
  • @patternfly/react-integration@2.15.1
  • @patternfly/react-table@2.16.7
  • @patternfly/react-topology@2.7.16
  • @patternfly/react-virtualized-extension@1.1.101

Thanks for your contribution! 🎉

Copy link
Contributor

mcoker left a comment

🤠👍

@tlabaj tlabaj mentioned this pull request Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.