Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Expandable): Support uncontrolled expandable #2649

Merged
merged 5 commits into from Aug 21, 2019

Conversation

@jessiehuff
Copy link
Contributor

jessiehuff commented Aug 6, 2019

Fixes #2350

Jessie added 2 commits Aug 6, 2019
Jessie
Jessie
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Aug 6, 2019

PatternFly-React preview: https://patternfly-react-pr-2649.surge.sh

Jessie
@tlabaj tlabaj self-assigned this Aug 6, 2019
@tlabaj tlabaj requested review from tlabaj and jschuler Aug 6, 2019
Copy link
Contributor

tlabaj left a comment

Can you add the uncontrolled expandable to the integration app and add some test. Can you also add unit test.

@jessiehuff

This comment has been minimized.

Copy link
Contributor Author

jessiehuff commented Aug 8, 2019

Sure thing! I'm on it. :)

Jessie added 2 commits Aug 8, 2019
Jessie
Jessie
Copy link
Contributor

jenny-s51 left a comment

LGTM! Supports expandable without an isExpanded prop, as required. 🎉

@redallen redallen dismissed tlabaj’s stale review Aug 21, 2019

Integration test added

@redallen redallen merged commit 2755e36 into patternfly:master Aug 21, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Aug 21, 2019

Your changes have been released in:

  • @patternfly/react-core@3.90.0
  • @patternfly/react-docs@4.10.20
  • @patternfly/react-inline-edit-extension@2.10.16
  • demo-app-ts@2.21.0
  • @patternfly/react-integration@2.21.0
  • @patternfly/react-table@2.18.10
  • @patternfly/react-topology@2.7.41
  • @patternfly/react-virtualized-extension@1.1.127

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.