Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dropdown): pass event object through onSelect #2657

Merged
merged 1 commit into from Aug 7, 2019

Conversation

@kmcfaul
Copy link
Contributor

kmcfaul commented Aug 7, 2019

What: fixes missing event passthrough on internal onSelect callback

Fixes issue: #2658

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Aug 7, 2019

PatternFly-React preview: https://patternfly-react-pr-2657.surge.sh

@tlabaj
tlabaj approved these changes Aug 7, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj merged commit 078fe56 into patternfly:master Aug 7, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Aug 7, 2019

Your changes have been released in:

  • @patternfly/react-core@3.82.4
  • @patternfly/react-docs@4.9.23
  • @patternfly/react-inline-edit-extension@2.9.68
  • demo-app-ts@2.15.4
  • @patternfly/react-table@2.16.8
  • @patternfly/react-topology@2.7.17
  • @patternfly/react-virtualized-extension@1.1.102

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.