Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(loginForm): adds autoFocus to username input #2659

Merged
merged 3 commits into from Aug 21, 2019

Conversation

@jenny-s51
Copy link
Contributor

jenny-s51 commented Aug 7, 2019

Closes #1954.

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Aug 7, 2019

PatternFly-React preview: https://patternfly-react-pr-2659.surge.sh

@tlabaj tlabaj self-assigned this Aug 8, 2019
@tlabaj tlabaj requested a review from kmcfaul Aug 9, 2019
@@ -71,7 +71,7 @@ export const LoginForm: React.FunctionComponent<LoginFormProps> = ({
{helperText}
</FormHelperText>
<FormGroup label={usernameLabel} isRequired isValid={isValidUsername} fieldId="pf-login-username-id">
<TextInput
<TextInput autoFocus

This comment has been minimized.

Copy link
@redallen

redallen Aug 20, 2019

Contributor

Can we add a noFocus prop in case a consumer doesn't want this new behaviour? Otherwise, nice find!!!

@jenny-s51 jenny-s51 force-pushed the jenny-s51:iss1954 branch from 03b28e8 to 82a79bc Aug 21, 2019
@jenny-s51 jenny-s51 requested a review from redallen Aug 21, 2019
Copy link
Contributor

redallen left a comment

Thanks! 🎉

@redallen redallen merged commit 9a1f1c7 into patternfly:master Aug 21, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Aug 21, 2019

Your changes have been released in:

  • @patternfly/react-core@3.90.1
  • @patternfly/react-docs@4.10.22
  • @patternfly/react-inline-edit-extension@2.10.17
  • demo-app-ts@2.21.1
  • @patternfly/react-table@2.18.11
  • @patternfly/react-topology@2.7.42
  • @patternfly/react-virtualized-extension@1.1.128

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.