Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Checkbox): Updated ids so none repeat #2663

Merged
merged 1 commit into from Aug 8, 2019

Conversation

@rebeccaalpert
Copy link
Member

rebeccaalpert commented Aug 7, 2019

Prevents inconsistent checking behavior when labels are clicked for uncontrolled vs. controlled
examples.

Fixes #2619.

Prevents inconsistent checking behavior when labels are clicked for uncontrolled vs. controlled
examples

Fixes #2619
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Aug 7, 2019

PatternFly-React preview: https://patternfly-react-pr-2663.surge.sh

Copy link
Contributor

jessiehuff left a comment

LGTM! :)

@tlabaj
tlabaj approved these changes Aug 8, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj merged commit 6319986 into patternfly:master Aug 8, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@rebeccaalpert rebeccaalpert deleted the rebeccaalpert:radio-bugfix branch Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.