Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Checkbox): Updated ids so none repeat #2663

Merged
merged 1 commit into from Aug 8, 2019

Conversation

rebeccaalpert
Copy link
Member

Prevents inconsistent checking behavior when labels are clicked for uncontrolled vs. controlled
examples.

Fixes #2619.

Prevents inconsistent checking behavior when labels are clicked for uncontrolled vs. controlled
examples

Fixes patternfly#2619
@rebeccaalpert rebeccaalpert added bug 🐛 PF4 React issues for the PF4 core effort labels Aug 7, 2019
@patternfly-build
Copy link
Contributor

PatternFly-React preview: https://patternfly-react-pr-2663.surge.sh

Copy link
Contributor

@jessiehuff jessiehuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tlabaj tlabaj merged commit 6319986 into patternfly:master Aug 8, 2019
@rebeccaalpert rebeccaalpert deleted the radio-bugfix branch August 8, 2019 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PF4 React issues for the PF4 core effort
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PF4 Uncontrolled checkbox in surge docs checks wrong checkbox when clicking label
4 participants