Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Page): Change the defaultManagedSidebarOpen prop name for co… #2664

Merged
merged 1 commit into from Aug 8, 2019

Conversation

@tlabaj
Copy link
Contributor

tlabaj commented Aug 7, 2019

…nsistency

#2662

What: Since we are prerelease we are changing the prop name to be consistent with other components that have a similar prop for default behaviour.

Additional issues:

@tlabaj tlabaj added the PF4 label Aug 7, 2019
@tlabaj tlabaj requested review from jschuler, dlabaj and jenny-s51 Aug 7, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Aug 7, 2019

PatternFly-React preview: https://patternfly-react-pr-2664.surge.sh

@jenny-s51 jenny-s51 self-requested a review Aug 8, 2019
Copy link
Contributor

jenny-s51 left a comment

LGTM 🙂

@jschuler jschuler merged commit 364c920 into patternfly:master Aug 8, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.