Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Table): add new visibleOn and hiddenOn breakpoint #2676

Merged
merged 2 commits into from Aug 19, 2019

Conversation

@kmcfaul
Copy link
Contributor

kmcfaul commented Aug 9, 2019

What: Adds the new 2xl breakpoint to visibleOn and hiddenOn classes.

Refer to issue: #2436

@priley86 Is there a good way to add tests for this? I'm unfamiliar with table and unsure how it uses the Visibility object.

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Aug 9, 2019

PatternFly-React preview: https://patternfly-react-pr-2676.surge.sh

@priley86

This comment has been minimized.

Copy link
Member

priley86 commented Aug 12, 2019

this looks good to me @kmcfaul. I believe it would be great to add unit tests in Table.tests.tsx for this after #2360 lands. We can add some new tests for columnTransforms there I'm guessing.

@kmcfaul kmcfaul force-pushed the kmcfaul:table-2xl-breakpoint branch from 6d7497a to 5055e13 Aug 19, 2019
@jschuler jschuler merged commit 701461f into patternfly:master Aug 19, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Aug 19, 2019

Your changes have been released in:

  • @patternfly/react-inline-edit-extension@2.10.6
  • @patternfly/react-table@2.18.0

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.