Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Select): add disabled flag for component #2678

Merged
merged 4 commits into from Aug 9, 2019

Conversation

@kmcfaul
Copy link
Contributor

kmcfaul commented Aug 9, 2019

What: Adds isDisabled flag to select.

Refer to issue: #2366

@kmcfaul

This comment has been minimized.

Copy link
Contributor Author

kmcfaul commented Aug 9, 2019

Requires core to be updated to v2.26 to get styling, in #2668

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Aug 9, 2019

PatternFly-React preview: https://patternfly-react-pr-2678.surge.sh

kmcfaul added 2 commits Jul 31, 2019
awaiting core merge for disabled styling
…ead form sub-elements
@kmcfaul kmcfaul force-pushed the kmcfaul:select-disabled branch from e1180c2 to fcfb875 Aug 9, 2019
Copy link
Contributor

tlabaj left a comment

just a typo to fix

Copy link
Contributor

mcoker left a comment

great job @kmcfaul! 🥇

Copy link
Contributor

tlabaj left a comment

LGTM

constructor(props) {
super(props);
this.options = [
{ value: 'Alabama', disabled: false },

This comment has been minimized.

Copy link
@jschuler

jschuler Aug 9, 2019

Collaborator

I'd remove the disabled keys from the options array in the two added examples for clarity purposes

This comment has been minimized.

Copy link
@tlabaj

tlabaj Aug 9, 2019

Contributor

I was thinking they same thing. But thought it was fine. You are right though, it would be more clear.

Copy link
Contributor

jessiehuff left a comment

LGTM! :)

Copy link
Collaborator

jschuler left a comment

How about instead of adding more examples just to demonstrate this, add a checkbox to an existing example that can toggle isDisabled?

@tlabaj

This comment has been minimized.

Copy link
Contributor

tlabaj commented Aug 9, 2019

@jschuler , I think the examples are fine as is. They match core.

@kmcfaul kmcfaul dismissed stale reviews from jessiehuff and tlabaj via 5d8e002 Aug 9, 2019
@tlabaj
tlabaj approved these changes Aug 9, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@jschuler jschuler merged commit a72124f into patternfly:master Aug 9, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Aug 9, 2019

Your changes have been released in:

  • @patternfly/react-core@3.86.0
  • @patternfly/react-docs@4.10.2
  • @patternfly/react-inline-edit-extension@2.9.75
  • demo-app-ts@2.19.0
  • @patternfly/react-integration@2.19.0
  • @patternfly/react-table@2.16.14
  • @patternfly/react-topology@2.7.23
  • @patternfly/react-virtualized-extension@1.1.109

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.