Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(LoginPage): Add attributes to the submit button #2682

Merged
merged 1 commit into from Sep 17, 2019

Conversation

@laviro
Copy link
Collaborator

laviro commented Aug 11, 2019

What:
Added the ability to pass additional attributes to the login page submit button

@laviro laviro force-pushed the fix/login_submit_btn_attr branch from 8cb7b09 to eab373d Aug 11, 2019
@tlabaj tlabaj added the PF3 label Aug 12, 2019
@tlabaj

This comment has been minimized.

Copy link
Contributor

tlabaj commented Aug 12, 2019

Hi. Is there an issue associated with this PR?

@redallen redallen closed this Aug 15, 2019
@redallen redallen deleted the fix/login_submit_btn_attr branch Aug 15, 2019
@laviro

This comment has been minimized.

Copy link
Collaborator Author

laviro commented Aug 15, 2019

@tlabaj no, but we need to add this ability in our project.
@redallen why did you close it?

@redallen redallen restored the fix/login_submit_btn_attr branch Aug 15, 2019
@redallen

This comment has been minimized.

Copy link
Contributor

redallen commented Aug 15, 2019

Apologies, I cleaned up all the extraneous branches off the repo this morning.

@redallen redallen reopened this Aug 15, 2019
Copy link
Member

jeff-phillips-18 left a comment

LGTM but could you add a unit test for this change?

@kmcfaul

This comment has been minimized.

Copy link
Contributor

kmcfaul commented Aug 29, 2019

lgtm as well, will approve when unit test goes in

@laviro laviro force-pushed the fix/login_submit_btn_attr branch from eab373d to c0059fe Sep 9, 2019
@laviro

This comment has been minimized.

Copy link
Collaborator Author

laviro commented Sep 9, 2019

Updated with a unit test

@laviro laviro requested review from jeff-phillips-18 and kmcfaul Sep 9, 2019
@tlabaj
tlabaj approved these changes Sep 17, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj merged commit 26320f3 into master Sep 17, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@ares

This comment has been minimized.

Copy link

ares commented Sep 17, 2019

awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.