Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Icons - config): Publish configs as well with icons #2701

Merged
merged 1 commit into from Aug 23, 2019

Conversation

@karelhala
Copy link
Contributor

karelhala commented Aug 14, 2019

What:
Some usecases require the original SVG path to be used instead of React component (for instance when using icons in svg). So this PR will introduce iconConfig (for each icon) alongSide the exported icon.

Additional issues:

@karelhala karelhala requested review from dlabaj, jschuler, redallen and tlabaj Aug 14, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Aug 14, 2019

PatternFly-React preview: https://patternfly-react-pr-2701.surge.sh


export default {{name}};
export default createIcon({{name}}Config);

This comment has been minimized.

Copy link
@redallen

redallen Aug 14, 2019

Contributor

I like this approach.

@jschuler jschuler merged commit 6055e91 into patternfly:master Aug 23, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.