Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(charts): add bullet chart #2708

Merged
merged 2 commits into from Aug 19, 2019
Merged

Conversation

@dlabrecq
Copy link
Member

dlabrecq commented Aug 15, 2019

This PR adds the bullet chart component.

Note that new theme variables will be added to PatternFly core via a separate PR.

Worked from @mceledonia 's color mock, using the latest PF color scales:
https://docs.google.com/document/d/1cw10pJFXWruB1SA8TQwituxn5Ss6KpxYPCOYGrH8qAY/edit

And included features from the existing design on pf.org:
See https://www.patternfly.org/v3/pattern-library/data-visualization/bullet-chart/#design

Fixes #1600

There are various examples available via the demo, but here are a few snapshots:

Screen Shot 2019-08-15 at 1 56 07 PM

Screen Shot 2019-08-15 at 2 01 56 PM

Screen Shot 2019-08-15 at 1 56 29 PM

Screen Shot 2019-08-15 at 1 56 41 PM

Screen Shot 2019-08-15 at 1 57 38 PM

Screen Shot 2019-08-15 at 1 57 50 PM

@dlabrecq dlabrecq requested a review from jschuler Aug 15, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Aug 15, 2019

@dlabrecq dlabrecq requested a review from redallen Aug 15, 2019
@dlabrecq dlabrecq force-pushed the dlabrecq:1600-bullet-chart branch from 07814fc to aa12925 Aug 15, 2019
@dlabrecq dlabrecq force-pushed the dlabrecq:1600-bullet-chart branch from aa12925 to ca6ffb3 Aug 15, 2019
@dlabrecq dlabrecq requested a review from mceledonia Aug 15, 2019
Copy link

mceledonia left a comment

Looks good to me, thanks Dan.

@dlabrecq dlabrecq requested a review from redallen Aug 15, 2019
@dlabrecq dlabrecq force-pushed the dlabrecq:1600-bullet-chart branch 6 times, most recently from dff869f to e5afccd Aug 17, 2019
@dlabrecq dlabrecq removed the request for review from jschuler Aug 19, 2019
@dlabrecq dlabrecq force-pushed the dlabrecq:1600-bullet-chart branch from e5afccd to cb7fc0b Aug 19, 2019
@dlabrecq dlabrecq dismissed stale reviews from kmcfaul, redallen, and mceledonia via 08f5576 Aug 19, 2019
@dlabrecq dlabrecq force-pushed the dlabrecq:1600-bullet-chart branch from cb7fc0b to 08f5576 Aug 19, 2019
@dlabrecq dlabrecq requested review from mceledonia, redallen and kmcfaul Aug 19, 2019
Copy link
Contributor

redallen left a comment

🎖

@redallen redallen merged commit c871fff into patternfly:master Aug 19, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Aug 19, 2019

Your changes have been released in:

  • @patternfly/react-charts@4.8.0
  • @patternfly/react-core@3.89.0
  • @patternfly/react-docs@4.10.16
  • @patternfly/react-inline-edit-extension@2.10.12
  • demo-app-ts@2.20.4
  • @patternfly/react-table@2.18.6
  • @patternfly/react-topology@2.7.37
  • @patternfly/react-virtualized-extension@1.1.123

Thanks for your contribution! 🎉

@dlabrecq dlabrecq deleted the dlabrecq:1600-bullet-chart branch Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.