Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(textarea): handle uncontrolled default value #2712

Merged
merged 1 commit into from Aug 29, 2019

Conversation

@redallen
Copy link
Contributor

redallen commented Aug 15, 2019

What: Fixes #2705

Additional issues:

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Aug 15, 2019

PatternFly-React preview: https://patternfly-react-pr-2712.surge.sh

@boaz0
boaz0 approved these changes Aug 16, 2019
Copy link
Member

boaz0 left a comment

LGTM 👍

@redallen redallen requested review from tlabaj, dlabaj, jschuler and kmcfaul Aug 16, 2019
@redallen redallen requested a review from jenny-s51 Aug 19, 2019
Copy link
Contributor

jenny-s51 left a comment

Looking good! 👍 Just so you know, @seanforyou23 has a similar PR up for this at #2698, but since yours is the one with a demo, I think Michael's can be closed

Copy link
Contributor

jessiehuff left a comment

LGTM

Copy link
Contributor

TheRealJon left a comment

/lgtm

@TheRealJon TheRealJon merged commit b0524b8 into patternfly:master Aug 29, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Aug 29, 2019

Your changes have been released in:

  • @patternfly/react-core@3.94.2
  • @patternfly/react-docs@4.10.33
  • @patternfly/react-inline-edit-extension@2.11.8
  • demo-app-ts@2.21.12
  • @patternfly/react-table@2.19.8
  • @patternfly/react-topology@2.8.8
  • @patternfly/react-virtualized-extension@1.1.139

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.