Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Ansible icon): Add ansible tower icon to custom icons definition #2735

Merged
merged 1 commit into from Aug 20, 2019

Conversation

@karelhala
Copy link
Contributor

karelhala commented Aug 20, 2019

What:
Since Ansible Tower is RH product, let's add it's icon to our icon drawer as well so app devs can include it in their apps.

Screenshot from 2019-08-20 10-55-21

Additional issues:

@karelhala karelhala requested review from dlabaj, tlabaj, jschuler and redallen Aug 20, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Aug 20, 2019

PatternFly-React preview: https://patternfly-react-pr-2735.surge.sh

@AllenBW

This comment has been minimized.

Copy link
Contributor

AllenBW commented Aug 20, 2019

This is SO long over due. 🥰🥰🥰🥰

Copy link
Contributor

AllenBW left a comment

🤤🤤🤤🤓🤓🤓🥳🥳🥳

Copy link
Contributor

redallen left a comment

Pretty.

@boaz0
boaz0 approved these changes Aug 20, 2019
Copy link
Member

boaz0 left a comment

LGTM 👍

Copy link
Contributor

jessiehuff left a comment

LGTM! :)

@redallen redallen merged commit 0ffe527 into patternfly:master Aug 20, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Aug 20, 2019

Your changes have been released in:

  • @patternfly/react-charts@4.8.1
  • @patternfly/react-core@3.89.2
  • @patternfly/react-docs@4.10.18
  • @patternfly/react-inline-edit-extension@2.10.14
  • demo-app-ts@2.20.6
  • @patternfly/react-table@2.18.8
  • @patternfly/react-topology@2.7.39
  • @patternfly/react-virtualized-extension@1.1.125
  • @patternfly/react-icons@3.11.0

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.