Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(select): add support for toggle icon #2748

Merged
merged 1 commit into from Aug 27, 2019
Merged

Conversation

@boaz0
Copy link
Member

boaz0 commented Aug 21, 2019

What:

closes #1767

//cc @mcoker @dlabrecq

@mcoker

This comment has been minimized.

Copy link
Contributor

mcoker commented Aug 26, 2019

@boaz0 looks like there are some conflicts.

@boaz0

This comment has been minimized.

Copy link
Member Author

boaz0 commented Aug 26, 2019

@mcoker thanks I will resolve that today.

@boaz0 boaz0 force-pushed the boaz0:closes_1767 branch from 092e0be to 0aed49d Aug 26, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Aug 26, 2019

PatternFly-React preview: https://patternfly-react-pr-2748.surge.sh

Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>
@boaz0 boaz0 force-pushed the boaz0:closes_1767 branch from 0aed49d to 86af69c Aug 26, 2019
@boaz0

This comment has been minimized.

Copy link
Member Author

boaz0 commented Aug 26, 2019

For some reason FilterIcon is undefined... 🤔

@mcoker
mcoker approved these changes Aug 26, 2019
Copy link
Contributor

mcoker left a comment

LGTM! Thanks @boaz0!!

@redallen redallen merged commit f5c3a94 into patternfly:master Aug 27, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Aug 27, 2019

Your changes have been released in:

  • @patternfly/react-core@3.94.0
  • @patternfly/react-docs@4.10.31
  • @patternfly/react-inline-edit-extension@2.11.6
  • demo-app-ts@2.21.10
  • @patternfly/react-table@2.19.6
  • @patternfly/react-topology@2.8.6
  • @patternfly/react-virtualized-extension@1.1.137

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.