Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upfix(switch): use defaultChecked instead of checked #2749
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
|
PatternFly-React preview: https://patternfly-react-pr-2749.surge.sh |
This comment has been minimized.
This comment has been minimized.
|
@redallen seems like you need to resolve a conflict or two. |
This comment has been minimized.
This comment has been minimized.
|
Rebased. |
This was referenced Sep 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
redallen commentedAug 21, 2019
•
edited
What: Fixes #2669 and actually changes the
<input>'scheckedprop in the DOM for our Switch. This is a somewhat tricky React bug, but the solution is to usedefaultCheckedinstead ofchecked. Settingchecked={true}orchecked={false}has no effect in the DOM outside of the first render, which is semantically incorrect.Additional issues: