Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(virtual-table): debounce resize event #2754

Merged
merged 1 commit into from Aug 30, 2019

Conversation

@priley86
Copy link
Member

priley86 commented Aug 21, 2019

What:
After further review in OpenShift, we need to debounce/throttle the resize event which handles resizing the virtualized grid. Failure to do so can lead to inconsistent grid sizing.

See fix in console.

Additional issues:

@priley86 priley86 force-pushed the priley86:virtual-table-resize branch from 9adf4a2 to 0120632 Aug 21, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Aug 21, 2019

PatternFly-React preview: https://patternfly-react-pr-2754.surge.sh

@tlabaj

This comment has been minimized.

Copy link
Contributor

tlabaj commented Aug 29, 2019

HI @priley86 is there an issue associated with this one?

@priley86

This comment has been minimized.

Copy link
Member Author

priley86 commented Aug 29, 2019

opened 2798 for this just now @tlabaj

@tlabaj tlabaj requested a review from mturley Aug 29, 2019
@tlabaj
tlabaj approved these changes Aug 30, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj merged commit 435bf96 into patternfly:master Aug 30, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.