Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust legend position for axis label #2763

Merged
merged 1 commit into from Aug 26, 2019

Conversation

@dlabrecq
Copy link
Member

dlabrecq commented Aug 22, 2019

In Cost Management, we want to use the chart's embedded legend, but also with an axis label. Currently, the legend and axis label occupy the same vertical position. This change simply adjusts the legend if an axis label is in use.

Fixes #2762

Screen Shot 2019-08-22 at 4 18 53 PM

@dlabrecq dlabrecq changed the title fix(charts): adjust legend position for axis label Adjust legend position for axis label Aug 22, 2019
@dlabrecq dlabrecq requested a review from redallen Aug 22, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Aug 22, 2019

PatternFly-React preview: https://patternfly-react-pr-2763.surge.sh

@dlabrecq dlabrecq force-pushed the dlabrecq:2762-axis-label-legend branch 4 times, most recently from 6b3e0ce to d817def Aug 23, 2019
@dlabrecq dlabrecq force-pushed the dlabrecq:2762-axis-label-legend branch from d817def to 2235943 Aug 25, 2019
@dlabrecq dlabrecq merged commit 6a93c7c into patternfly:master Aug 26, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Aug 26, 2019

Your changes have been released in:

  • @patternfly/react-charts@4.8.4

Thanks for your contribution! 🎉

@dlabrecq dlabrecq deleted the dlabrecq:2762-axis-label-legend branch Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.