Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(catalog-tile): custom icon jsx for react-extensions CatalogTile #2771

Merged
merged 1 commit into from Aug 27, 2019

Conversation

@priley86
Copy link
Member

priley86 commented Aug 23, 2019

What:
Closes #2770

cc: @jeff-phillips-18 @christianvogt

Additional issues:

@priley86 priley86 requested a review from jeff-phillips-18 Aug 23, 2019
@christianvogt

This comment has been minimized.

Copy link

christianvogt commented Aug 23, 2019

@priley86 the other icon options apply catalog-tile-pf-icon. The size is no longer controlled if supplying a component as an icon. Is this intended? Do you expect the dev to explicitly supply an catalog-tile-pf-icon or equivalent?

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Aug 23, 2019

PatternFly-React preview: https://patternfly-react-pr-2771.surge.sh

@jeff-phillips-18

This comment has been minimized.

Copy link
Member

jeff-phillips-18 commented Aug 23, 2019

@priley86 @christianvogt I think wrapping the provided icon component in a span with the catalog-tile-pf-icon class would work to keep the icon the correct size.

@priley86 priley86 force-pushed the priley86:catalog-tile-icon branch from 54e458c to cefc614 Aug 26, 2019
@priley86

This comment has been minimized.

Copy link
Member Author

priley86 commented Aug 26, 2019

actually... will not work... we have to have a way to prevent icon from rendering too I assume. Will tweak once more.
ok, i think this should do it.

PTAL @jeff-phillips-18 @christianvogt

@priley86 priley86 force-pushed the priley86:catalog-tile-icon branch from cefc614 to de43831 Aug 26, 2019
@priley86 priley86 force-pushed the priley86:catalog-tile-icon branch from de43831 to 8790765 Aug 26, 2019
@redallen redallen merged commit 694cd04 into patternfly:master Aug 27, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Aug 27, 2019

Your changes have been released in:

  • patternfly-react-extensions@2.20.0

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.