Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Icon): New icon path missing #2817

Merged
merged 1 commit into from Sep 9, 2019

Conversation

@karelhala
Copy link
Contributor

karelhala commented Sep 3, 2019

What:
Screenshot from 2019-09-03 10-34-19

Additional issues:
Closes: #2836

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Sep 3, 2019

PatternFly-React preview: https://patternfly-react-pr-2817.surge.sh

Copy link
Contributor

redallen left a comment

I thought the path was missing.

Copy link
Contributor

tlabaj left a comment

Looks great! Can you add the related issue to description please.

@karelhala

This comment has been minimized.

Copy link
Contributor Author

karelhala commented Sep 4, 2019

@tlabaj sure thing, issue added to PR description.

Copy link
Contributor

tlabaj left a comment

LGTM

Copy link
Contributor

tlabaj left a comment

We can get this in once conflicts are resolved

@karelhala karelhala dismissed stale reviews from tlabaj, kmcfaul, and redallen via 5bafac9 Sep 6, 2019
@karelhala karelhala force-pushed the karelhala:path-missing-icon branch from f6fe8f2 to 5bafac9 Sep 6, 2019
@tlabaj
tlabaj approved these changes Sep 9, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@jschuler jschuler merged commit cc225cf into patternfly:master Sep 9, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Sep 9, 2019

Your changes have been released in:

  • @patternfly/react-charts@4.9.7
  • @patternfly/react-core@3.102.1
  • @patternfly/react-docs@4.12.3
  • @patternfly/react-inline-edit-extension@2.11.29
  • demo-app-ts@2.24.2
  • @patternfly/react-table@2.20.9
  • @patternfly/react-topology@2.8.28
  • @patternfly/react-virtualized-extension@1.2.17
  • @patternfly/react-icons@3.14.0

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.