Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
feat(Modal): add modifier to left align Modal footer #2835
This looks good now @tlabaj . I just have one question to float out there. This example looks odd to me now:
I'm wondering if we should just remove that and have a separate component or variation for something like this with a centered button (which is what I would expect). I don't see this example in core. @mcoker @kybaker @mceledonia what do you think? If I'm the only one bothered by this, I'm ok to leave it alone.
@mcarrano hmmm. We do have this example in core, but we show how to use the existing modal close button without a header - https://pf4.patternfly.org/components/ModalBox/examples/
Personally I think we should update the react example to match, assuming that's the preferred design approach for a modal without a header (to use the existing close button versus a custom one), since we don't have an example for that in react currently.
Then I think we could discuss if we need to add another example that removes the modal's close button and demonstrates how to use a custom button to close the modal. If we do provide that example, I guess how we present that would depend on whether we want to either officially support or recommend a design for that use case. If we support it, we could add a variant to the footer that positions the custom close button. If we just recommend a design, maybe we use the flex layout as a demo of how we suggest doing it. Or do we just leave it as is, demonstrating how to add the button, but not necessarily recommending a design for the button's placement.
Your changes have been released in:
Thanks for your contribution!