Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Spinner): Add Spinner to experimental #2858

Merged
merged 3 commits into from Sep 6, 2019
Merged

Conversation

@tlabaj
Copy link
Contributor

tlabaj commented Sep 5, 2019

Fixes #2753

What:

Additional issues:

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Sep 5, 2019

PatternFly-React preview: https://patternfly-react-pr-2858.surge.sh

@mcoker

This comment has been minimized.

Copy link
Contributor

mcoker commented Sep 5, 2019

Hmm... for some reason the reset styles are being loaded after the component styles again. The global reset styles for background-color: transparent are overriding the background color for the lead/tail-ball elements, so the edges aren't rounded.

Screen Shot 2019-09-05 at 4 02 25 PM

core

Screen Shot 2019-09-05 at 4 00 09 PM

react

Screen Shot 2019-09-05 at 4 00 15 PM

Copy link
Member

mcarrano left a comment

Looks good to me, but @mceledonia can you give this a look and let me know if this behaves as expected?

Titani
@dlabaj
dlabaj approved these changes Sep 6, 2019
Copy link
Contributor

jessiehuff left a comment

LGTM! :)

@mcoker
mcoker approved these changes Sep 6, 2019
Copy link
Contributor

mcoker left a comment

🏆

typescript: true
propComponents: ['Spinner']
section: 'experimental'
---

This comment has been minimized.

Copy link
@redallen

redallen Sep 6, 2019

Contributor

For this to show up properly on -org, we are using a new stage: 'early' in the frontmatter. I'll address this in a follow-up PR.

@mceledonia

This comment has been minimized.

Copy link

mceledonia commented Sep 6, 2019

I'm getting rendering artifacts but I trust @redallen 's diagnosis of my gpu causing them! Other than that it looks great to me.

@mcarrano mcarrano removed the ux review label Sep 6, 2019
Copy link
Member

mcarrano left a comment

If @mceledonia is good, then I'm good!

@redallen redallen merged commit 77afa63 into patternfly:master Sep 6, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@redallen redallen removed the css review label Sep 6, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Sep 6, 2019

Your changes have been released in:

  • @patternfly/react-core@3.100.0
  • @patternfly/react-docs@4.12.0
  • @patternfly/react-inline-edit-extension@2.11.26
  • demo-app-ts@2.23.0
  • @patternfly/react-integration@2.23.0
  • @patternfly/react-table@2.20.6
  • @patternfly/react-topology@2.8.25
  • @patternfly/react-virtualized-extension@1.2.14

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.